shojiiii commented on code in PR #39712:
URL: https://github.com/apache/superset/pull/39712#discussion_r3238213279
##########
superset/utils/json.py:
##########
@@ -194,6 +194,7 @@ def dumps( # pylint: disable=too-many-arguments
separators: Union[tuple[str, str], None] = None,
cls: Union[type[simplejson.JSONEncoder], None] = None,
encoding: Optional[str] = "utf-8",
+ ensure_ascii: bool = True,
) -> str:
Review Comment:
Added docstring entries for both `\encoding` and `ensure_ascii` in
`superset.utils.json.dumps()` so the new behavior is documented explicitly in
[ff5ae81](https://github.com/apache/superset/pull/39712/commits/ff5ae81619e5408bb2a7a5d156693c1f02a9c4db).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
