rusackas commented on PR #39304: URL: https://github.com/apache/superset/pull/39304#issuecomment-4452469725
The fix itself is correct and the approach is reasonable, but the test coverage gap and the decorator-duplication maintenance risk are worth addressing before merge. Resolving the remaining open Copilot threads and adding at least one integration test would make this mergeable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
