rusackas commented on PR #39301: URL: https://github.com/apache/superset/pull/39301#issuecomment-4452492658
A few things before approving: - The blocklist is fail-open — ip.is_global should be the primary gate; multicast, reserved, and 0.0.0.0 ranges currently slip through - In validate_data_uri, a falsy hostname silently passes instead of raising - Test coverage is ~21% on the security-critical paths — worth shoring up before merge Happy to approve once the blocklist and coverage gaps are addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
