bito-code-review[bot] commented on PR #40138:
URL: https://github.com/apache/superset/pull/40138#issuecomment-4456131575
<!-- Bito Reply -->
The flagged issue is correct—the test named for UNION ALL uses plain UNION,
leaving the UNION ALL regression untested. To resolve, change UNION to UNION
ALL in the SQL string. No other comments exist on this PR.
**tests/unit_tests/sql/parse_tests.py**
```
def test_with_clause_containing_union_all_is_not_mutating_oracle() -> None:
"""
Companion to test_with_clause_containing_union_is_not_mutating: the
original bug report (#25659) used the exact Oracle-flavored shape below
(``SYSDATE FROM DUAL`` is the Oracle no-op for "now"). Pinning the
verbatim repro guards against a future dialect-specific regression that
a generic ``SELECT 1`` test might miss.
"""
sql = """
WITH SET1 AS (SELECT SYSDATE FROM DUAL UNION ALL SELECT SYSDATE FROM
DUAL),
SET2 AS (SELECT * FROM SET1)
SELECT * FROM SET2
"""
assert not SQLScript(sql, "oracle").has_mutation()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
