bito-code-review[bot] commented on PR #40139: URL: https://github.com/apache/superset/pull/40139#issuecomment-4456142646
<!-- Bito Reply --> The flagged issue is correct: the new ed25519 regression test will fail deterministically because SSHManager.create_tunnel hard-codes RSA key parsing, causing an 'unpack requires 4 bytes' error when trying to parse ed25519 keys. To resolve, update the key loading logic to use paramiko's polymorphic loader instead of RSAKey. **superset/extensions/ssh.py** ``` import io # In SSHManager.create_tunnel, replace the RSA-specific line: # Original: RSAKey.from_private_key(private_key_file, ssh_tunnel.private_key_password) # Fixed: paramiko.PKey.from_private_key(io.StringIO(private_key), password=ssh_tunnel.private_key_password) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
