gkneighb commented on PR #39900: URL: https://github.com/apache/superset/pull/39900#issuecomment-4456199784
Thanks @aminghadersohi for the review! Both items addressed: 1. **`success` assertions added** to every test in commit `3c9600ca` — `assert ... ["success"] is True` on happy paths (20), `assert ... ["success"] is False` on each of the 5 error paths (dataset_not_found, permission_denied, validation_error, generation_failed, plus the exception-handler test). 2. **PR description updated** to drop the `ExploreLinkError` reference (carryover from an earlier design we pivoted away from) and accurately describe the reused `ChartGenerationError`-from-`common/error_schemas.py` shape. On the NIT: I tried typing `error` as a nested Pydantic model (`ChartGenerationError | None`) in an earlier iteration, but FastMCP couldn't serialize the nested model on the wire — the response came back as TextContent with the inner `message` string and `structured_content` was `None`. Falling back to `dict[str, Any] | None` with `.model_dump()` at the call sites was what made the schema actually round-trip correctly. Happy to revisit if you know a FastMCP pattern that handles nested Pydantic models. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
