bito-code-review[bot] commented on code in PR #40147:
URL: https://github.com/apache/superset/pull/40147#discussion_r3246202190
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/buildQuery.ts:
##########
@@ -23,16 +23,39 @@ import {
} from '@superset-ui/core';
export default function buildQuery(formData: QueryFormData) {
- const { x_axis, granularity_sqla, groupby } = formData;
+ const {
+ x_axis,
+ granularity_sqla,
+ groupby,
+ nonCumulative,
+ metricStart,
+ metricEnd,
+ } = formData as any;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Avoid any types</b></div>
<div id="fix">
The code uses 'any' type for formData destructuring, bypassing TypeScript
type checking. The proper EchartsWaterfallFormData type exists and should be
used instead. Also, the destructuring uses 'x_axis' but the type defines
'xAxis', so update to match.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
QueryFormData,
+ QueryObject,
} from '@superset-ui/core';
+import { EchartsWaterfallFormData } from './types';
export default function buildQuery(formData: EchartsWaterfallFormData) {
const {
- x_axis,
+ xAxis,
granularity_sqla,
groupby,
nonCumulative,
metricStart,
metricEnd,
- } = formData as any;
+ } = formData;
const columns = [
- ...ensureIsArray(x_axis || granularity_sqla),
+ ...ensureIsArray(xAxis || granularity_sqla),
...ensureIsArray(groupby),
];
return buildQueryContext(formData, baseQueryObject => {
- const queryObject: any = {
+ const queryObject: QueryObject = {
...baseQueryObject,
columns,
orderby: columns?.map(column => [column, true]),
};
// Only override metrics in non-cumulative mode
if (nonCumulative) {
const metrics = [
...ensureIsArray(metricStart),
...ensureIsArray(metricEnd),
].filter(Boolean);
if (metrics.length) {
queryObject.metrics = metrics;
}
}
return [queryObject];
});
}
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/bdf1b20/.cursor/rules/dev-standard.mdc#L16";>dev-standard.mdc:16</a>
</li>
</ul>
</details>
<small><i>Code Review Run #62c1d8</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
