bito-code-review[bot] commented on PR #40169: URL: https://github.com/apache/superset/pull/40169#issuecomment-4459858153
<!-- Bito Reply --> The flagged issue is correct — hiding all nested `label` elements with `display: none` removes them from the accessibility tree, leaving form controls in the popover without proper accessible naming, which degrades UX for screen readers. To resolve this, scope the styling to only the specific visual label you want hidden and use a visually-hidden pattern (e.g., a utility class that hides visually but preserves accessibility) instead of removing labels entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
