GitHub user pbfrias17 added a comment to the discussion: SQLLab query limits not being respected
After stepping through the code, it looks like this is where we try to set the query limit: https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/commands/sql_lab/execute.py#L154-L157 But this is the part of the update method that is being executed https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/daos/base.py#L429. I would think it should call the `merge` function since we're [saving a new query object just before trying to update the limit](https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/commands/sql_lab/execute.py#L145) GitHub link: https://github.com/apache/superset/discussions/40172#discussioncomment-16933265 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
