Elengar opened a new pull request, #40180: URL: https://github.com/apache/superset/pull/40180
### SUMMARY Fixes temporal drill-to-detail and cross-filter requests that send JavaScript epoch-millisecond values for temporal columns. Pivot and table interactions can emit filters such as `install_date == "1778630400000"` or `install_date IN ["1777248000000"]`. For BigQuery and ClickHouse-backed datasets, those values can compile as raw string literals against temporal columns and fail at query time. This change coerces temporal scalar and IN-list filter values through the active engine spec before SQL compilation, and normalizes pivot/table interaction output so temporal epoch values are emitted as numbers where possible. Fixes #36776 Fixes #40167 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. This change does not alter the rendered UI. ### TESTING INSTRUCTIONS - `pytest tests/unit_tests/models/helpers_test.py -q` - `SKIP=prettier-frontend,helm-docs pre-commit run --files $(git diff --name-only origin/master...HEAD)` - Verify a dashboard cross-filter on a temporal table or pivot header sends a successful chart-data request when the filter contains an epoch-millisecond value. - Verify a drill-to-detail request for a BigQuery or ClickHouse-backed temporal column compiles the filter as an engine-specific temporal literal instead of a raw epoch string. ### ADDITIONAL INFORMATION - [x] Has associated issue: #36776, #40167 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
