bito-code-review[bot] commented on code in PR #40186:
URL: https://github.com/apache/superset/pull/40186#discussion_r3252426131
##########
pyproject.toml:
##########
@@ -101,7 +101,7 @@ dependencies = [
"slack_sdk>=3.19.0, <4",
"sqlalchemy>=1.4, <2",
"sqlalchemy-utils>=0.38.0, <0.43", # expanding lowerbound to work with
pydoris
- "sqlglot>=28.10.0, <29",
+ "sqlglot>=28.10.0, <31",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dependency version mismatch</b></div>
<div id="fix">
The pyproject.toml upper bound was expanded from <29 to <31, but
requirements/base.txt (line 1) and requirements/development.txt still pin the
exact version `sqlglot==28.10.0`. The requirements/README.md states that `.txt`
files are auto-generated from pyproject.toml and that 'all version numbers for
shared library should fully match at all times'. This inconsistency can cause
CI/pipeline failures when the generated files are out of sync with the
manifest. Regenerate the requirements files using `./scripts/uv-pip-compile.sh`
and include them in this PR.
</div>
</div>
<small><i>Code Review Run #7667e3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
