ya-nsh commented on PR #40181: URL: https://github.com/apache/superset/pull/40181#issuecomment-4467738024
Addressed the latest Bito review note in 1ce1060: the filtered-state regression test now asserts the dimmed-state properties ( and label override) in addition to the zero border/gap values. I also resolved both bot review threads.\n\nValidation:\n- npm run test -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- npm run lint -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- uvx pre-commit run --files superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
