dpgaspar commented on a change in pull request #8163: [SQLLab] Refactor sql json endpoint URL: https://github.com/apache/incubator-superset/pull/8163#discussion_r322564184
########## File path: superset/views/core.py ########## @@ -715,6 +715,68 @@ def shortner(self): appbuilder.add_view_no_menu(R) +class SQLJsonParams: Review comment: I agree, I don't like it either (the SQLJsonParams class), it was an idea around a data structure for all those `request.form` parameters, that could be passed around to other class methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
