venkatamandavilli-code commented on issue #24290: URL: https://github.com/apache/superset/issues/24290#issuecomment-4471360714
I agree this naming feels a bit outdated now. Since the permission is no longer limited to CSV export specifically, `supersetCanCSV` can definitely be misleading when it also controls Excel or image download functionality. A name like `supersetCanDownload` or something more capability-oriented would probably make the intent clearer and easier to understand for future contributors working in this area. The only thing worth checking carefully would be backward compatibility or downstream usage, since this property may already be referenced in multiple frontend components or custom deployments. Overall though, the proposed rename seems reasonable and improves readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
