madhushreeag commented on PR #40178: URL: https://github.com/apache/superset/pull/40178#issuecomment-4472095700
> ### Code Review Agent Run #919152 > Actionable Suggestions - 0 > Additional Suggestions - 2 > * superset/security/manager.py - 2 > > * Potentially undefined schema reference · [Line 200-200](https://github.com/apache/superset/pull/40178/files#diff-bcb3868b9e29aea5f6e87ec641120dae35a86d732501f488a7a6dbdeb450f5c1R200) > The OpenAPI spec references `RoleUserPutSchema` but I couldn't verify this schema exists in the codebase. Per rule [10906], documentation must accurately reflect implemented code. Ensure the schema is properly defined or update the reference. > * Missing audit logging for role users update · [Line 181-247](https://github.com/apache/superset/pull/40178/files#diff-bcb3868b9e29aea5f6e87ec641120dae35a86d732501f488a7a6dbdeb450f5c1R181) > Add `_log_audit_event("RoleUsersUpdated", {"role_id": role_id, "user_ids": [u.id for u in users]})` before the response to log role user assignment changes. > > Filtered by Review Rules > Review Details > Bito Usage Guide > AI Code Review powered by [<img alt="Bito Logo" width="50" height="20" src="https://camo.githubusercontent.com/810f9c950a15f18a9a21d4e214820ef360ea3b08a4b5dea95d24529fffd09ed6/68747470733a2f2f6269746f2e61692f77702d636f6e74656e742f75706c6f6164732f323032332f31302f4c6f676f2d4269746f2d426c61636b2d63726f707065642e737667";>](https://bito.ai/) RoleUserPutSchema is defined in flask_appbuilder/security/sqla/apis/role/schema.py and registered into the OpenAPI spec by the base RoleApi class that SupersetRoleApi inherits from. The $ref is valid and resolves correctly at runtime; it just isn't visible in the Superset source tree since it lives in the installed FAB package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
