puneetdixit200 opened a new pull request, #40200:
URL: https://github.com/apache/superset/pull/40200
### SUMMARY
Preserve the BigQuery project/catalog when looking up time partition
metadata.
`get_time_partition_column` previously called `client.get_table()` with
only `dataset.table`, so the BigQuery client
could fall back to the credentials/default project and return a 404 for
cross-project datasets. The lookup now uses
`project.dataset.table` when `Table.catalog` is available.
Fixes #40131
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable.
### TESTING INSTRUCTIONS
Automated checks:
- `venv\Scripts\python.exe -m pytest
tests\unit_tests\db_engine_specs\test_bigquery.py -q`
- `venv\Scripts\python.exe -m ruff format --check
superset\db_engine_specs\bigquery.py
tests\unit_tests\db_engine_specs\test_bigquery.py`
- `venv\Scripts\python.exe -m ruff check
superset\db_engine_specs\bigquery.py
tests\unit_tests\db_engine_specs\test_bigquery.py`
- `git diff --check`
Manual verification:
1. Configure a BigQuery database where the credentials project differs
from the dataset project.
2. Select a schema/dataset from the dataset project.
3. Open metadata for a time-partitioned table.
4. Confirm metadata loads without a 404 from the credentials/default
project.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #40131
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
