aminghadersohi commented on code in PR #39604: URL: https://github.com/apache/superset/pull/39604#discussion_r3253539033
########## superset/mcp_service/mcp_config.py: ########## @@ -20,12 +20,15 @@ import secrets from typing import Any, Dict, Optional +from fastmcp.server.auth.providers.jwt import JWTVerifier Review Comment: To confirm: `mcp_config.py` is only ever imported from MCP-specific code paths that are themselves lazy-loaded (e.g. `core_mcp_injection.py` wraps all mcp imports in functions). Non-MCP deployments never touch this module. If you'd prefer an explicit guard (`try/except ImportError`) let me know and I'll add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
