betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the 
backend
URL: 
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530062997
 
 
   > In general I think all the error messages could use a little work, mainly 
phrasing them from the perspective an end user would have. These errors would 
reflect a failure to save the query on the backend, and could result in lost 
data, so we should let the user know that.
   
   Thanks, I worked on the error messages making them actionable. Granted, most 
of them simply say "please contact your administrator", but there's not much 
the user can do except for trying saving the query.
   
   > Also, it looks like if the sync to the backend fails, then we don't 
perform the action on the client side, and that we also synchronously wait for 
the backend sync to finish before making the client side change. Maybe instead 
we should be optimistically updating the UI immediately and then firing off the 
request (and reverting the UI back if the query fails). Not sure how much 
latency this adds in actuality.
   
   In my tests there was no perceived latency, since the payload and the 
response are both usually very small. I think it might be more confusing to 
adjust the UI optimistically and revert it when the sync fails.
   
   > As a side note, should we expose a button to the user to manually save the 
query if they see the error message? I worry that people will freak out about 
losing data once they see this new update.
   
   I added a message telling them to click "Save Query" when an error happens. 
I don't think we do a good job in letting users know that they should 
explicitly save the queries they care about, and this was discussed last week 
during the design brainstorm with Cartel. I think later we'll rethink the way 
query organization work, and we can iterate on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to