AliGouta commented on code in PR #40223:
URL: https://github.com/apache/superset/pull/40223#discussion_r3261804799
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx:
##########
@@ -224,15 +224,19 @@ export default function getControlItemsMap({
<>
{typeof controlItem.config.label === 'function'
? (controlItem.config.label as Function)()
- : controlItem.config.label}
+ : typeof controlItem.config.label === 'string'
Review Comment:
@hainenber I considered this simple option to fix the issue, well, I just
created a new PR with another option:
[option 2-fix translation
issue](https://github.com/apache/superset/pull/40229). It seems there is a
problem loading the i118 translation package when rendering. in option 2, I
consider another option which might be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
