rusackas opened a new pull request, #40231:
URL: https://github.com/apache/superset/pull/40231

   ### SUMMARY
   
   This is a **test-only PR** opened as a TDD-style validation of issue #27500.
   
   #27500 (filed 2024-03) reports that sorting the chart list by *last 
modified* visually returns rows out of order — i.e. the humanized column shown 
to the user does not match the underlying timestamp order.
   
   This PR adds one regression test on the chart list API:
   
   1. **`test_get_charts_changed_on_delta_humanized_sort_monotonic`** — inserts 
two charts with explicit `changed_on` timestamps (one 2 days old, one now), 
queries 
`/api/v1/chart/?order_column=changed_on_delta_humanized&order_direction=desc` 
filtered to those two rows, and asserts the newer chart appears before the 
older one.
   
   ### How to interpret CI
   
   - **CI green** → the backend sort key for `changed_on_delta_humanized` 
correctly reflects timestamp order; merging closes #27500 and locks in the 
regression guard. If the issue persists for users, the remaining suspect is the 
frontend (humanization rendering, not server sort).
   - **CI red** → backend ordering is wrong. Likely suspect: how 
`changed_on_delta_humanized` is mapped to a sort column in 
`superset/charts/api.py` (`order_columns`).
   
   ### TESTING INSTRUCTIONS
   
   \`\`\`bash
   pytest 
tests/integration_tests/charts/api_tests.py::TestChartApi::test_get_charts_changed_on_delta_humanized_sort_monotonic
 -v
   \`\`\`
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: closes #27500
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to