bito-code-review[bot] commented on PR #40231: URL: https://github.com/apache/superset/pull/40231#issuecomment-4482392987
<!-- Bito Reply --> The PR comment indicates a logic error in the regression test for sorting by `changed_on_delta_humanized`. The current test uses `now` and `2 days ago`, which may not catch a backend bug that sorts by the humanized string instead of the timestamp. To fix this, the test should use timestamp pairs that break lexical sorting, such as `10 days ago` and `2 days ago`. This will ensure the test detects incorrect sort keys. The fix involves updating the test to use these timestamp values. **tests/integration_tests/charts/api_tests.py** ``` now = datetime.utcnow() chart_older.changed_on = now - timedelta(days=10) chart_newer.changed_on = now - timedelta(days=2) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
