Abdulrehman-PIAIC80387 commented on PR #39940: URL: https://github.com/apache/superset/pull/39940#issuecomment-4485376651
@hainenber Thanks for the review — addressed: - **Reordered** so the security/passthrough check runs before any return (as you suggested). - **Switched `!path` → `path == null`** per the Bito secondary suggestion, so empty strings still get the app-root prefix (matches the docstring "null or undefined"). - **Added two tests** covering `null` / `undefined` input (the missing coverage codecov flagged). `pathUtils.test.ts`: 19/19 pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
