betodealmeida commented on code in PR #40222:
URL: https://github.com/apache/superset/pull/40222#discussion_r3268500804
##########
superset/semantic_layers/mapper.py:
##########
@@ -588,6 +590,125 @@ def _convert_query_object_filter(
}
+def _coerce_filter_value(
+ value: FilterValues | frozenset[FilterValues],
+ dimension: Dimension,
+) -> FilterValues | frozenset[FilterValues]:
+ if isinstance(value, frozenset):
+ return frozenset(_coerce_scalar_filter_value(v, dimension) for v in
value)
+ return _coerce_scalar_filter_value(value, dimension)
+
+
+def _coerce_scalar_filter_value( # noqa: C901
+ value: FilterValues, dimension: Dimension
+) -> FilterValues:
+ if value is None:
+ return None
+
+ dtype = dimension.type
+
+ if pa.types.is_boolean(dtype):
+ if isinstance(value, bool):
+ return value
+ if isinstance(value, str):
+ parsed = value.strip().lower()
+ if parsed in {"true", "t", "1", "yes", "y", "on"}:
+ return True
+ if parsed in {"false", "f", "0", "no", "n", "off"}:
+ return False
+ raise ValueError(
+ f"Invalid boolean value {value!r} for filter column
{dimension.name}"
+ )
+
+ if pa.types.is_integer(dtype):
+ if isinstance(value, bool):
+ raise ValueError(
+ f"Invalid integer value {value!r} for filter column
{dimension.name}"
+ )
+ if isinstance(value, int):
+ return value
+ if isinstance(value, str):
+ try:
+ return int(value.strip())
+ except ValueError as ex:
+ raise ValueError(
+ f"Invalid integer value {value!r} for filter column "
+ f"{dimension.name}"
+ ) from ex
+ raise ValueError(
+ f"Invalid integer value {value!r} for filter column
{dimension.name}"
+ )
+
+ if pa.types.is_floating(dtype) or pa.types.is_decimal(dtype):
+ if isinstance(value, bool):
+ raise ValueError(
+ f"Invalid numeric value {value!r} for filter column
{dimension.name}"
+ )
+ if isinstance(value, (int, float)):
+ return float(value)
+ if isinstance(value, str):
+ try:
+ return float(value.strip())
+ except ValueError as ex:
+ raise ValueError(
+ f"Invalid numeric value {value!r} for filter column "
+ f"{dimension.name}"
+ ) from ex
+ raise ValueError(
+ f"Invalid numeric value {value!r} for filter column
{dimension.name}"
+ )
Review Comment:
`FilterValues` in `superset_core` is currently `str | int | float | bool |
datetime.* | None` and doesn't include `Decimal`, so a clean fix needs that
union widened plus changes to `cache._comparable` and every semantic-view
backend that consumes `Filter.value`. For typical decimal columns (≤ ~15
significant digits) the float path is lossless. Tracking as follow-up; added an
inline note explaining the tradeoff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
