bito-code-review[bot] commented on code in PR #40254:
URL: https://github.com/apache/superset/pull/40254#discussion_r3269313742
##########
docs/yarn.lock:
##########
@@ -4828,100 +4828,100 @@
dependencies:
"@types/yargs-parser" "*"
-"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.59.3":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.59.3.tgz#5d6da7e7b236b46452fa00d3904bb6f59615bfde";
- integrity
sha512-PwFvSKsXGShKGW6n5bZOhGHEcCZXM8HofLK9fNsEwZXzFRjoY+XT1Vsf1zgyXdwTr0ZYz1/2tkZ0DBTT9jZjhw==
+"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.59.3":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.59.4.tgz#c67bfee32caae9cb587dce1ac59c3bf43b659707";
+ integrity
sha512-PegsU+XfyJJNjd4+u/k6f9yTyp0lEXXiPopUNobZcIAUJFGICFLN+sP0Rb3JehVmiij1Ph0dFGYqODoRo/2+6A==
dependencies:
"@eslint-community/regexpp" "^4.12.2"
- "@typescript-eslint/scope-manager" "8.59.3"
- "@typescript-eslint/type-utils" "8.59.3"
- "@typescript-eslint/utils" "8.59.3"
- "@typescript-eslint/visitor-keys" "8.59.3"
+ "@typescript-eslint/scope-manager" "8.59.4"
+ "@typescript-eslint/type-utils" "8.59.4"
+ "@typescript-eslint/utils" "8.59.4"
+ "@typescript-eslint/visitor-keys" "8.59.4"
ignore "^7.0.5"
natural-compare "^1.4.0"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.59.3":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.59.3.tgz#f46cbc70ae0a25119ef94eac9ecd46714788e1a1";
- integrity
sha512-HPwA+hVkfcriajbNvTmZv4VRauibay+cWArYUYq7u7W7PmGShMxbPxLvrwDme55a6d5alG3nrYfhyJ/G28XlLg==
+"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.59.3":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.59.4.tgz#77d99e3b27663e7a22cf12c3fb769db509e5e93c";
+ integrity
sha512-zORHqO/tuhxY1zWuTvMUqddRxpiFJ72xVfcNoWpqdLjs6lfPbuQBJuW4pk+49/uBMy7Ssr4bzgjiKmmDB1UbZQ==
dependencies:
- "@typescript-eslint/scope-manager" "8.59.3"
- "@typescript-eslint/types" "8.59.3"
- "@typescript-eslint/typescript-estree" "8.59.3"
- "@typescript-eslint/visitor-keys" "8.59.3"
+ "@typescript-eslint/scope-manager" "8.59.4"
+ "@typescript-eslint/types" "8.59.4"
+ "@typescript-eslint/typescript-estree" "8.59.4"
+ "@typescript-eslint/visitor-keys" "8.59.4"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.59.3.tgz#1be5ae152aad987a156c9a1a9b4256e75cfbbe0c";
- integrity
sha512-ECiUWa/KYRGDFUqTNehaRgzDshnJfkTABJxVemHk4ko22gcr0ukloKjWvyQ64g8YCV/UI47kN1dbmjf/GaQYng==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.59.4.tgz#5830535a0e7a3ae806e2669964f47a74c4bc6b0e";
+ integrity
sha512-Ly00Vu4oAacfDeHp2Zg85ioNG6l8HG+tN1D7J+xTHSxu9y0awYKJ2zH1rFBn8ZSfuGK+7FxK3Cgl3uAz0aZZLg==
dependencies:
- "@typescript-eslint/tsconfig-utils" "^8.59.3"
- "@typescript-eslint/types" "^8.59.3"
+ "@typescript-eslint/tsconfig-utils" "^8.59.4"
+ "@typescript-eslint/types" "^8.59.4"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.59.3.tgz#91a60f66803fe9dae0696fbab2451f5723f119d2";
- integrity
sha512-t2LvZnoEfzKtnPjgeEu41xw5gxq9mQVfYy4OoZ4Vlt0sk3JwxmhCca/AR7DwOiHrjWgjAj6as4AhRLKSDfvZIA==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.59.4.tgz#507d1258c758147dac1adee9517a205a8ac1e046";
+ integrity
sha512-mUeR/3H1WrTAddJrwut8OoPjfauaztMQmRwV5fQTUyNVJCLiUXXe4lGEyYIL2oFDpP7UtgbGJXCt72wT0z2S3Q==
dependencies:
- "@typescript-eslint/types" "8.59.3"
- "@typescript-eslint/visitor-keys" "8.59.3"
+ "@typescript-eslint/types" "8.59.4"
+ "@typescript-eslint/visitor-keys" "8.59.4"
-"@typescript-eslint/[email protected]",
"@typescript-eslint/tsconfig-utils@^8.59.3":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.59.3.tgz#88ca9036b42ccdd1e630cfdafd2e042c2ca6a835";
- integrity
sha512-PcIJHjmaREXLgIAIzLnSY9VucEzz8FKXsRgFa1DmdGCK/5tJpW03TKJF01Q6VZd1lLdz2sIKPWaDUZN9dp//dw==
+"@typescript-eslint/[email protected]",
"@typescript-eslint/tsconfig-utils@^8.59.4":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.59.4.tgz#218ba229d96dde35212e3a76a7d0a6bc831398be";
+ integrity
sha512-DLCpnKgD4alVxTBSKulK+gU1KCqOgUXfDRDXh2mZgzokQKa/70ax93I2uVO3m/LLvIAtWZIFoiifudmIqAxpMA==
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.59.3.tgz#421fb2448bdfeb301d134a01cd02503f67fd8192";
- integrity
sha512-g71d8QD8UaiHGvrJwyIS1hCX5r63w6Jll+4VEYhEAHXTDIqX1JgxhTAbEHtKntL9kuc4jRo7/GWw5xfCepSccQ==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.59.4.tgz#359fc53ba39a1f1860fddda40ebe5bfe0d87faed";
+ integrity
sha512-uonTuPAAKr9XaBGqJ3LjYTh72zy5DyGesljO9gtmk/eFW0W1fRHjnwVYKB35Lm8d5Q5CluEW3gPHjTvZTmgrfA==
dependencies:
- "@typescript-eslint/types" "8.59.3"
- "@typescript-eslint/typescript-estree" "8.59.3"
- "@typescript-eslint/utils" "8.59.3"
+ "@typescript-eslint/types" "8.59.4"
+ "@typescript-eslint/typescript-estree" "8.59.4"
+ "@typescript-eslint/utils" "8.59.4"
debug "^4.4.3"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]", "@typescript-eslint/types@^8.59.3":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.59.3.tgz#b7ca539c5e302fdde9a7cadb73caed107ef8f2cd";
- integrity
sha512-ePFoH0g4ludssdRFqqDxQePCxU4WQyRa9+XVwjm7yLn0FKhMeoetC+qBEEI1Eyb1pGSDveTIT09Bvw2WhlGayg==
+"@typescript-eslint/[email protected]", "@typescript-eslint/types@^8.59.4":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.59.4.tgz#c29d5c21bfbaa8347ddc677d3ac1fcd2db0f848e";
+ integrity
sha512-F1o7WJcCq+bc8dwcO/YsSEOudAH8RDtaOhM6wcAQhcUsFhnWQl81JKy48q1hoxAU0qrzM89+31GYh1515Zde3Q==
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.59.3.tgz#e6bb1408e00b47e431427a40268db4e86cb121ab";
- integrity
sha512-CbRjVRAf7Lr9Kr8RopKcbY45p2VfmmHrm0ygOCYFi7oU8q19m0Fs/6iHS7kNOmwpp+ob07ZVcAqlxUod9lYdmg==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.59.4.tgz#d005e5e1fb425526f39685594bed34a04ad755ea";
+ integrity
sha512-F+RuOmcDXo4+TPdfd/TCLS3m2nw8gE9XXyZLrA3JBfaA5tz9TtdkyD3YJFmPxulyc2cKbEok/CvFE3MgSLWnag==
dependencies:
- "@typescript-eslint/project-service" "8.59.3"
- "@typescript-eslint/tsconfig-utils" "8.59.3"
- "@typescript-eslint/types" "8.59.3"
- "@typescript-eslint/visitor-keys" "8.59.3"
+ "@typescript-eslint/project-service" "8.59.4"
+ "@typescript-eslint/tsconfig-utils" "8.59.4"
+ "@typescript-eslint/types" "8.59.4"
+ "@typescript-eslint/visitor-keys" "8.59.4"
debug "^4.4.3"
minimatch "^10.2.2"
semver "^7.7.3"
tinyglobby "^0.2.15"
ts-api-utils "^2.5.0"
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.59.3.tgz#f693f979deb4dc3994de03ff8b23976d625c36c5";
- integrity
sha512-JAvT14goBzRzzzZyqq3P9BLArIxTtQURUtFgQ/V7FO+eU+Gg6ES+5ymOPP1wRxXcxAYeivCk4uS3jCKWI1K8Zg==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.59.4.tgz#8ccd2b08aecc72c7efc0d7ac6695631d199d256e";
+ integrity
sha512-cYXeNAUsG4lJo5dbc1FcKm+JwIWrj1/UpTORsC6tGMjEZ81DYcvIr9/ueikhMa/Y/gDQYGp+YX9/xQrXje5BJw==
dependencies:
"@eslint-community/eslint-utils" "^4.9.1"
- "@typescript-eslint/scope-manager" "8.59.3"
- "@typescript-eslint/types" "8.59.3"
- "@typescript-eslint/typescript-estree" "8.59.3"
+ "@typescript-eslint/scope-manager" "8.59.4"
+ "@typescript-eslint/types" "8.59.4"
+ "@typescript-eslint/typescript-estree" "8.59.4"
-"@typescript-eslint/[email protected]":
- version "8.59.3"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.59.3.tgz#820843b1b5ca4290009cf189382abcf6fe00dfa6";
- integrity
sha512-f1UQF7ggd42YiwI5wGrRaPsa+P0CINBlrkLPmGfpq/u/I/oVtecoEIfFR9ag/oa1sLOsRNZ6xehf6qMZhQGBDg==
+"@typescript-eslint/[email protected]":
+ version "8.59.4"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.59.4.tgz#1ac23b747b011f5cbdb449da97769f6c5f3a9355";
+ integrity
sha512-U3gxVaDVnuZKhSspW/MzMxE1kq7zOdc072FcSNoqA1I9p8HyKbBFfEHoWckBAMgNMph4MamwS5iTVzFmrnt8TQ==
dependencies:
- "@typescript-eslint/types" "8.59.3"
+ "@typescript-eslint/types" "8.59.4"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Lock file manual edit violation</b></div>
<div id="fix">
Lock file was manually edited to bump @typescript-eslint packages from
8.59.3 to 8.59.4, but docs/package.json still specifies ^8.59.3. This violates
the rule against manual lock file edits (BITO.md rule [10438]). Run `yarn
install` after updating package.json to regenerate yarn.lock with correct
integrity hashes.
</div>
</div>
<small><i>Code Review Run #c1d34b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
