sadpandajoe commented on code in PR #40140:
URL: https://github.com/apache/superset/pull/40140#discussion_r3269844000
##########
superset/commands/dashboard/importers/v1/utils.py:
##########
@@ -212,6 +229,11 @@ def update_cross_filter_scoping(
if old_id in id_map
]
+ # Cross-filter chartsInScope mirrors the native-filter case.
+ cross_filters = chart_config.get("crossFilters")
+ if isinstance(cross_filters, dict):
+ _remap_charts_in_scope(cross_filters, id_map)
Review Comment:
`global_chart_configuration.chartsInScope` (lines 196–203 above, inside this
same function) doesn't get this remap. Might be good to add to this and then
add a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
