bito-code-review[bot] commented on PR #40282: URL: https://github.com/apache/superset/pull/40282#issuecomment-4495251277
<!-- Bito Reply --> The PR comments file contains only one comment thread with the architectural review suggestion. The suggestion recommends validating dashboard existence and ownership during dry-run requests by executing command-level validation without persisting changes. This would ensure proper 404/403 responses for invalid/unauthorized dashboards even in dry-run mode. **superset/dashboards/api.py** ``` 1065:1068: def put_colors(self, dry_run=False): 1066: if dry_run: 1067: return 200 1068: UpdateDashboardColorsConfigCommand(...).run() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
