bito-code-review[bot] commented on PR #40285: URL: https://github.com/apache/superset/pull/40285#issuecomment-4496131346
<!-- Bito Reply --> The PR comment file contains 1 comment row (excluding the header). Here's the full comment content: "Suggestion: The timestamp is recomputed on every `_name` access, not once per send. During a single email send flow, `_name` is read multiple times (subject plus attachment names), so if formatting includes seconds/minutes and execution crosses a boundary, subject and attachment filenames can disagree within the same message. Compute the current timestamp once per send (or once per notification rendering) and reuse it for all name/subject/attachment generation in that send. [logic error]" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
