msyavuz opened a new pull request, #40288: URL: https://github.com/apache/superset/pull/40288
### SUMMARY `open_sql_lab_with_context` was emitting `?title=…` on the generated `/sqllab` URL, but SQL Lab's `PopEditorTab` only reads `?name=…` (it destructures `name` straight into `QueryEditor.name`). The LLM-provided title was silently dropped, so MCP-opened tabs landed with no label at all — not even `Untitled Query N`. Keep the MCP-facing field as `title` (natural for LLMs), but emit it on the URL as `name` to match the existing frontend convention. Also tightened the schema description so models actually generate a descriptive label from conversation context instead of leaving the field unset. ```diff - params["title"] = request.title + params["name"] = request.title # PopEditorTab reads ?name= ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — backend-only change to a URL query parameter; tab label is just the user-visible string. ### TESTING INSTRUCTIONS 1. Call the `open_sql_lab_with_context` MCP tool with a `title` (e.g. `"Top customers by revenue"`). 2. Open the returned URL. 3. The SQL Lab tab should open with that title; previously it opened blank. 4. Unit tests: `pytest tests/unit_tests/mcp_service/sql_lab/tool/test_open_sql_lab_with_context.py`. ### ADDITIONAL INFORMATION - Has associated issue: No - Required feature flags: None - Changes UI: No — backend URL contract only; the tab label rendering already supports it - Includes DB Migration: No - Introduces new feature or API: No — fixes an existing one - Removes existing feature or API: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
