sha174n commented on PR #38847: URL: https://github.com/apache/superset/pull/38847#issuecomment-4498529024
@dpgaspar Done — `ReportModal` now calls `POST /api/v1/report/subscribe` for new subscriptions. `recipients`, `creation_method`, and `owners` are no longer sent from the frontend; all derived server-side. Edit path (PUT) unchanged. On permissions: no changes needed. `ReportSchedule` is in `ALPHA_ONLY_VIEW_MENUS` so `can_subscribe` is already alpha-only by inheritance. Gamma users can't reach the feature anyway — the frontend button is gated by `menu_access on Manage`, not ReportSchedule permissions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
