betodealmeida opened a new pull request, #40292: URL: https://github.com/apache/superset/pull/40292
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The OAuth2 callback page always emitted both `BroadcastChannel` and `localStorage` signals when `BroadcastChannel` was supported, so a single completion re-triggered `reRunQuery` / `triggerQuery` / `onRefresh` twice in the original tab. This PR makes the sender's storage path a true fallback (only when `BroadcastChannel` is unavailable or its construction throws), and guard the receiver against duplicate dispatches as a safety net. Additionally, it wraps channel/storage operations in `try/catch` so restricted contexts can't abort the flow, and stabilize the listener's effect by reading volatile selector values (`chartList`, `query`, etc.) from a `ref` so `chartList` changes don't churn the channel and open a race window. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
