richardfogaca commented on code in PR #40222:
URL: https://github.com/apache/superset/pull/40222#discussion_r3275466829
##########
superset/semantic_layers/mapper.py:
##########
@@ -547,16 +548,18 @@ def _convert_query_object_filter(
type=PredicateType.WHERE,
column=dimension,
operator=Operator.GREATER_THAN_OR_EQUAL,
- value=start,
+ value=_coerce_scalar_filter_value(start, dimension),
Review Comment:
**`superset/semantic_layers/mapper.py:551`**
Nice, this addresses the closed-range case. One edge case still looks worth
covering: Superset can represent open-ended ranges as `"2025-01-01 : "` or `" :
2025-12-31"`. With a date/timestamp semantic dimension, this path now tries to
coerce the empty side (`""`) and raises instead of emitting only the bounded
predicate.
WDYT - could we skip empty `start`/`end` values here and only add the
corresponding `>=` or `<` filter, plus a small regression test for open-ended
temporal ranges?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
