rebenitez1802 commented on code in PR #39465:
URL: https://github.com/apache/superset/pull/39465#discussion_r3275671882
##########
superset-frontend/src/features/roles/RoleListEditModal.tsx:
##########
@@ -146,41 +148,39 @@ function RoleListEditModal({
}, [addDangerToast, id]);
useEffect(() => {
- if (!stablePermissionIds.length) {
- setRolePermissions([]);
- setLoadingRolePermissions(false);
- return;
- }
-
+ let cancelled = false;
Review Comment:
small regression: Missing early-return for empty `permission_ids`
I'll suggest adding it back to prevent firing a request for roles with no
permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
