rusackas commented on PR #39448:
URL: https://github.com/apache/superset/pull/39448#issuecomment-4502609965
Thanks @aminghadersohi — addressed all five in 8e69649076:
1. **Plural-note batch bug** (the real one) — `build_prompt` now gates on
`any(item.get("msgid_plural") for item in batch)` instead of `batch[0]`, with a
regression test
(`test_build_prompt_includes_plural_note_when_plural_is_not_first`) that builds
a singular-first / plural-second batch and asserts the guidance lands in the
prompt.
2. **M1 `--no-fuzzy` help text** — strengthened to spell out the consequence
(fuzzy entries are filtered from `.mo`; removing the flag ships AI-generated
translations to end users without human review).
3. **M2 `--lang` path-traversal guard** — added
`re.fullmatch(r'[a-z]{2,3}(_[A-Z]{2})?', lang)` validation before constructing
the `.po` filesystem path; rejects values like `../../tmp/x` with a clear error.
4. **`--min-context` missing from module-docstring Options table** — added
it alongside the other flags.
5. **Misleading test comment** — rewrote the empty-list comment to describe
the actual control flow (`"[]"` parses as an empty list → falsy → scalar
broadcast), not JSONDecodeError.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
