jesperct commented on code in PR #40220:
URL: https://github.com/apache/superset/pull/40220#discussion_r3277181639


##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx:
##########
@@ -1418,7 +1418,7 @@ const FiltersConfigForm = (
                                           }}
                                         />
                                       </StyledRowFormItem>
-                                      {hasMetrics && (
+                                      {hasMetrics && !isChartCustomization && (

Review Comment:
   Confirmed — `processGroupByCustomizations` was still injecting 
`order_by_cols` from `sortMetric` and `GroupByFilterCard` was surfacing the 
value as "Aggregation". Fixed in f6f7700630: stripped `sortMetric` from the 
`ChartCustomization['controlValues']` type, the migration, the query path, and 
the filter-card display.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to