aminghadersohi commented on code in PR #40098:
URL: https://github.com/apache/superset/pull/40098#discussion_r3277202732
##########
tests/unit_tests/mcp_service/test_middleware.py:
##########
@@ -1030,12 +1030,232 @@ async def test_superset_exception_5xx_logs_error(self)
-> None:
error.status = 500
call_next = AsyncMock(side_effect=error)
+ mock_logger = MagicMock()
with (
patch("superset.mcp_service.middleware.get_user_id",
return_value=1),
patch("superset.mcp_service.middleware.event_logger"),
- patch("superset.mcp_service.middleware.logger") as mock_logger,
+ patch("superset.mcp_service.middleware.logger", mock_logger),
pytest.raises(ToolError, match="Internal error"),
):
await middleware.on_message(context, call_next)
mock_logger.error.assert_called()
+
+ @pytest.mark.asyncio
+ async def test_mcp_permission_denied_error_becomes_tool_error(self) ->
None:
+ """MCPPermissionDeniedError must convert to ToolError, not a generic
error."""
+ from superset.mcp_service.auth import MCPPermissionDeniedError
Review Comment:
why not upper level import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
