bito-code-review[bot] commented on code in PR #40297:
URL: https://github.com/apache/superset/pull/40297#discussion_r3277251235
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx:
##########
@@ -203,6 +205,30 @@ describe('SelectFilterPlugin', () => {
});
});
+ test('uses document.body as popup container in dashboard filter bar', () => {
+ const container = getSelectPopupContainer(AppSection.Dashboard, false);
+ expect(container(document.createElement('div'))).toBe(document.body);
+ });
+
+ test('uses parent ref as popup container for overflowed filters', () => {
+ const parentNode = document.createElement('div');
+ const container = getSelectPopupContainer(AppSection.Dashboard, true, {
+ current: parentNode,
+ });
+ expect(container()).toBe(parentNode);
+ });
+
+ test('keeps trigger parent popup container outside dashboard filter bar', ()
=> {
+ const triggerParent = document.createElement('div');
+ const trigger = document.createElement('div');
+ triggerParent.appendChild(trigger);
+ const container = getSelectPopupContainer(
+ AppSection.FilterConfigModal,
+ false,
+ );
+ expect(container(trigger)).toBe(triggerParent);
+ });
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test for FilterBar</b></div>
<div id="fix">
The implementation at lines 113-114 handles `AppSection.FilterBar` but no
test covers this case. The `AppSection` enum includes `FilterBar =
'FILTER_BAR'` (Base.ts:54) and the implementation explicitly checks for it. Add
a test: `test('uses document.body as popup container in filter bar', () => {
const container = getSelectPopupContainer(AppSection.FilterBar, false);
expect(container(document.createElement('div'))).toBe(document.body); });`
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
---
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
(lines 208-230) ---
208: test('uses document.body as popup container in dashboard filter
bar', () => {
209: const container = getSelectPopupContainer(AppSection.Dashboard,
false);
210:
expect(container(document.createElement('div'))).toBe(document.body);
211: });
212: +
213: + test('uses document.body as popup container in filter bar', () => {
214: + const container = getSelectPopupContainer(AppSection.FilterBar,
false);
215: +
expect(container(document.createElement('div'))).toBe(document.body);
216: + });
217: +
218: test('uses parent ref as popup container for overflowed filters', ()
=> {
219: const parentNode = document.createElement('div');
220: const container = getSelectPopupContainer(AppSection.Dashboard,
true, {
221: current: parentNode,
222: });
223: expect(container()).toBe(parentNode);
224: });
225: +
226: test('keeps trigger parent popup container outside dashboard filter
bar', () => {
227: const triggerParent = document.createElement('div');
228: const trigger = document.createElement('div');
229: triggerParent.appendChild(trigger);
230: const container = getSelectPopupContainer(
231: AppSection.FilterConfigModal,
232: false,
233: );
234: expect(container(trigger)).toBe(triggerParent);
235: });
```
</div>
</details>
</div>
<small><i>Code Review Run #06c067</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
