rusackas commented on PR #40040: URL: https://github.com/apache/superset/pull/40040#issuecomment-4503245584
Thanks for the NIT @aminghadersohi — addressed in eccd5482d9. Switched the two `useSelector<SqlLabRootState, T>` calls (`defaultVizType` at 224, `user` at 243) over to `useAppSelector` so the file no longer mixes typed-hooks with manually-annotated raw `useSelector`. Both selectors only touch `state.common` and `state.user` which are present on both `RootState` and `SqlLabRootState`, so no behavior change. Dropped the now-unused `SqlLabRootState` and `User` imports as a bonus. All 17 SaveDatasetModal tests still pass; tsc is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
