rusackas commented on PR #39703: URL: https://github.com/apache/superset/pull/39703#issuecomment-4503242556
Re: the mocker.spy follow-up suggestion — addressed in 77d843c7. Each parametrize case now carries a `should_warn` flag, and the test uses `mocker.spy(logger, "warning")` to assert: - Original silent cases (SupersetSecurityException, SupersetParseError, TemplateError) — `logger.warning` is NOT called. - New cases (DatasetNotFoundError, SupersetTemplateException) — `logger.warning` IS called exactly once. If anyone accidentally collapses the new cases into the silent handler, the test fails with a message pointing at the regression. Thanks @aminghadersohi for the catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
