codeant-ai-for-open-source[bot] commented on code in PR #39300:
URL: https://github.com/apache/superset/pull/39300#discussion_r3277629361
##########
superset-frontend/playwright.config.ts:
##########
@@ -132,6 +133,26 @@ export default defineConfig({
// No storageState = clean browser with no cached cookies
},
},
+ ...(process.env.INCLUDE_EMBEDDED
+ ? [
+ {
+ // Embedded dashboard tests - validates the full embedding flow:
+ // external app -> SDK -> iframe -> guest token -> dashboard
render.
+ // Each spec file mutates per-dashboard embedding state (UUID,
+ // allowed_domains) on a single shared Superset, so files must not
+ // run in parallel even if more are added later.
+ name: 'chromium-embedded',
+ testMatch: '**/tests/embedded/**/*.spec.ts',
+ fullyParallel: false,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not suggest project-level `workers` overrides in Playwright configs;
`workers` is top-level only. If a suite needs serialized execution, document
the constraint and adjust the top-level CI/test invocation instead of adding a
config workaround.
**Applied to:**
- `**/playwright.config.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
docker/pythonpath_dev/superset_config_docker_light.py:
##########
@@ -36,3 +38,32 @@
# Disable Celery entirely for lightweight mode
CELERY_CONFIG = None # type: ignore[assignment,misc]
+
+# Honor SUPERSET_FEATURE_<NAME> env vars on top of any flags inherited from
+# superset_config. Lets local dev/e2e enable features (e.g. EMBEDDED_SUPERSET)
+# without editing shipped config files. Only the literal string "true"
+# (case-insensitive) is treated as enabled — "1"/"yes"/"on" are not, matching
+# the strict-string convention used elsewhere in Superset's env parsing.
+FEATURE_FLAGS = {
+ **FEATURE_FLAGS, # noqa: F405
+ **{
+ name[len("SUPERSET_FEATURE_") :]: value.strip().lower() == "true"
+ for name, value in os.environ.items()
+ if name.startswith("SUPERSET_FEATURE_")
+ },
+}
+
+if os.environ.get("SUPERSET_FEATURE_EMBEDDED_SUPERSET", "").strip().lower() ==
"true":
+ # Disable Talisman so /embedded/<uuid> doesn't return
X-Frame-Options:SAMEORIGIN.
+ # Without this, browsers refuse to render Superset inside an iframe from a
+ # different origin (i.e. the embedded SDK use case). Production/CI
configures
+ # Talisman with explicit `frame-ancestors`; for the lightweight local
stack we
+ # just turn it off.
+ TALISMAN_ENABLED = False
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag disabling Talisman in lightweight dev-stack configs when the
change is explicitly documented as dev-only and the production/CI embedding
path remains unchanged.
**Applied to:**
- `docker/pythonpath_dev/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
