rusackas commented on PR #34562:
URL: https://github.com/apache/superset/pull/34562#issuecomment-4503408751
Applied all three review nits in ef6bada7:
1. **DRY** — hoisted `const pageSize = initialPageSize ?? DEFAULT_PAGE_SIZE`
above `paginationProps` and reused it in both branches + the deps array. The
existing `const pageSize` near the page-reset useEffect is now the same hoisted
constant, so the declaration appears once.
2. **Test selector stability** — swapped
`container.querySelector('.table-condensed')` for
`screen.getByTestId('listview-table')` (the `data-test` attribute is set
explicitly on TableCollection).
3. **Documented the type mismatch** — expanded the comment and added a TODO
above `data: mockData as unknown as Record<string, unknown>[][]` so
`SingleQueryResultPaneProp.data` can be reconciled in a follow-up.
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
