bito-code-review[bot] commented on PR #39508:
URL: https://github.com/apache/superset/pull/39508#issuecomment-4503708562
<!-- Bito Reply -->
The `catch` in `afterEach` suppresses rejections from the LaunchQueue
consumer, which can lead to false-positive test passes when background work
fails unexpectedly. The suggested fix is to re-throw the error after logging it
to ensure test failures are properly captured. This is a valid and important
fix to apply for maintaining test suite reliability.
**superset-frontend/src/pages/FileHandler/index.test.tsx**
```
await consumerPromise.catch(e => {
console.warn('LaunchQueue consumer rejected:', e);
throw e; // Re-throw to fail the test
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
