rusackas opened a new pull request, #40319: URL: https://github.com/apache/superset/pull/40319
### SUMMARY oxlint 1.66 (bumped via #40318) added support for two ESLint rules that were previously listed in `oxlint.json` as not-implemented. This PR enables them. **Rules enabled:** | Rule | Level | Violations | Action | |---|---|---:|---| | `import/newline-after-import` | `error` | 3 | Auto-fixed via `npx oxlint --fix` | | `react/no-unstable-nested-components` | `warn` | 150 | Surfaced as warnings with a TODO to graduate to `error` after a cleanup pass | The 3 `newline-after-import` errors were all simple missing blank lines after imports and were fully auto-fixable. They are now at **0 errors** in the config. The 150 `no-unstable-nested-components` violations require real refactoring (hoisting component definitions out of parent render functions) and are too risky to fix in a single PR. They are set to `"warn"` with an inline TODO comment so we can graduate them to `"error"` after a dedicated cleanup pass. **Note on `no-implied-eval`:** the user also asked about this rule — it was already enabled as `"error"` (`superset-frontend/oxlint.json:91`), so no change is needed there. **Also updated** the "Rules carried over from ESLint that oxlint does NOT implement" comment block (around lines 36-61) to remove these two rules from the not-implemented list. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — lint config change. ### TESTING INSTRUCTIONS ```bash cd superset-frontend npx oxlint --config oxlint.json 2>&1 | grep -c "import(newline-after-import)" # -> 0 npx oxlint --config oxlint.json 2>&1 | grep -c "react(no-unstable-nested-components)" # -> 150 (all warnings, non-blocking) ``` The newly introduced lint baseline contributes **0 new errors** to the build. Pre-existing errors on master (32x `require-to-throw-message`) are untouched. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
