betodealmeida commented on a change in pull request #8213: Better distinction
between tables and views, and show CREATE VIEW
URL:
https://github.com/apache/incubator-superset/pull/8213#discussion_r323442405
##########
File path: superset/assets/src/components/TableSelector.jsx
##########
@@ -203,6 +205,33 @@ export default class TableSelector extends
React.PureComponent {
{db.database_name}
</span>);
}
+ renderTableOption({ focusOption, focusedOption, key, option, selectValue,
style, valueArray }) {
+ const classNames = ['Select-option'];
+ if (option === focusedOption) {
+ classNames.push('is-focused');
+ }
+ if (valueArray.indexOf(option) >= 0) {
+ classNames.push('is-selected')
+ }
+ return (
+ <div
+ className={classNames.join(' ')}
+ key={key}
+ onClick={() => selectValue(option)}
Review comment:
The problem is that here `selectValue` (and `focusOption` below) are passed
as arguments in the function, so we need to create the object every time. :-/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
