EnxDev opened a new pull request, #40331: URL: https://github.com/apache/superset/pull/40331
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> `ALLOW_FULL_CSV_EXPORT` never actually raised the row limit. The flag only controlled frontend menu visibility no backend code consulted it. "Export to full .CSV" sent row_limit: `SQL_MAX_ROW`, and the global apply_max_row_limit cap then clamped it via min(SQL_MAX_ROW, limit). The two collapsed to the same number, so a "full" export could never exceed SQL_MAX_ROW (100k). The feature worked when introduced in #15046, but #16683 ("add global max row limit", 3 months later) silently neutralized it so it's been broken for tables larger than `SQL_MAX_ROW` ever since. **Fix**: when the flag is on, raise the export row limit to `TABLE_VIZ_MAX_ROW_SERVER` (a bounded, predictable ceiling) in the chart streaming export command, and on the frontend request so it matches. The global cap is left untouched; the export feature opts itself out via its own command rather than poking a hole in a shared safety guard. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> - Before https://github.com/user-attachments/assets/493521cb-44eb-4b60-8223-3c51441166db - After https://github.com/user-attachments/assets/36f3f6aa-b1cf-4bc3-84ac-d3680ee333b6 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Set feature flag ALLOW_FULL_CSV_EXPORT: True. 2. On a dashboard, add a table chart over a dataset with more than SQL_MAX_ROW rows. 3. Chart menu → Export to full .CSV → the downloaded file contains all rows (up to TABLE_VIZ_MAX_ROW_SERVER), not just SQL_MAX_ROW. Unit tests: pytest tests/unit_tests/commands/chart/streaming_export_command_test.py and npx jest Chart.test.tsx. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: ALLOW_FULL_CSV_EXPORT - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
