jesperct commented on PR #40220:
URL: https://github.com/apache/superset/pull/40220#issuecomment-4509289939

   Screenshots, before and after.
   
   Customization config (Sort Metric dropdown removed):
   
   Before:
   ![](https://files.catbox.moe/zmamzt.png)
   
   After:
   ![](https://files.catbox.moe/fzycta.png)
   
   Control dropdown with Sort descending enabled. Before, the toggle did 
nothing and values stayed A to Z. After, Z to A:
   
   Before:
   ![](https://files.catbox.moe/avbru7.png)
   
   After:
   ![](https://files.catbox.moe/zzukqe.png)
   
   The dropdown half needed one more commit (c8c41b9). The plugin had the 
comparator, but `GroupByFilterCard` rendered its own `<Select>` without it, so 
the toggle wasn't reaching the rendered UI. Wired `sortAscending` into that 
Select too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to