hy144328 commented on code in PR #40274:
URL: https://github.com/apache/superset/pull/40274#discussion_r3284469125
##########
pytest.ini:
##########
@@ -18,5 +18,30 @@
testpaths =
tests
python_files = *_test.py test_*.py *_tests.py *viz/utils.py
-addopts = -p no:warnings
+# `-p no:warnings` temporarily disabled in favor of more finely tuned
`filterwarnings`.
+#addopts = -p no:warnings
asyncio_mode = auto
+
+# `ignore` virtually reproduces to `-p no:warnings`.
+# Always print RemovedIn20Warning when SQLALCHEMY_WARN_20=1.
+# Additionally, raise errors for refactored RemovedIn20Warning cases to
prevent regression.
Review Comment:
Have you had a chance to look at #40273 ?
This PR is just to set the stage to crush one deprecation warning after
another or concurrently.
For instance, #40274 , #40275 and #40276 illustrate how to build on top of
this.
Each PR uncomments a warning type, and makes this comment correct.
Is this acceptable?
Otherwise, #40275 is quite low stakes, and I would be happy to get that
merged stacked with this one together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
