aminghadersohi commented on code in PR #40309:
URL: https://github.com/apache/superset/pull/40309#discussion_r3285740761
##########
superset/mcp_service/jwt_verifier.py:
##########
@@ -61,21 +62,47 @@
"_jwt_failure_reason", default=None
)
+_MCP_BROWSER_HELLO_HTML: str = (
+ _resource_files("superset.mcp_service")
+ .joinpath("hello.html")
+ .read_text(encoding="utf-8")
+)
Review Comment:
Good catch. The concern is valid — loading at module import time means a
missing would silently disable auth via the broad `except` in `mcp_config.py`.
Fixed in commit `fae756c881`: `_MCP_BROWSER_HELLO_HTML` is now `None` at module
level and populated lazily on first browser request via
`_get_browser_hello_html()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
