bito-code-review[bot] commented on code in PR #40302: URL: https://github.com/apache/superset/pull/40302#discussion_r3287136006
########## superset/mcp_service/theme/tool/get_theme_info.py: ########## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Get theme info FastMCP tool +""" + +import logging +from datetime import datetime, timezone + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.mcp_core import ModelGetInfoCore +from superset.mcp_service.theme.schemas import ( + GetThemeInfoRequest, + serialize_theme_object, + ThemeError, + ThemeInfo, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["discovery"], + class_permission_name="Theme", + annotations=ToolAnnotations( + title="Get theme info", + readOnlyHint=True, + destructiveHint=False, + ), +) +async def get_theme_info( + request: GetThemeInfoRequest, ctx: Context +) -> ThemeInfo | ThemeError: + """Get theme details by ID or UUID. + + Returns theme configuration including json_data. + + IMPORTANT FOR LLM CLIENTS: + - Use numeric ID (e.g., 123) or UUID string (e.g., "a1b2c3d4-...") + - To find a theme ID, use the list_themes tool first + + Example usage: + ```json + { + "identifier": 1 + } + ``` + + Or with UUID: + ```json + { + "identifier": "a1b2c3d4-5678-90ab-cdef-1234567890ab" + } + ``` + """ + await ctx.info( + "Retrieving theme information: identifier=%s" % (request.identifier,) + ) + + try: + from superset.daos.theme import ThemeDAO + + with event_logger.log_context(action="mcp.get_theme_info.lookup"): + get_tool = ModelGetInfoCore( + dao_class=ThemeDAO, + output_schema=ThemeInfo, + error_schema=ThemeError, + serializer=serialize_theme_object, + supports_slug=False, + logger=logger, + ) + + result = get_tool.run_tool(request.identifier) + + if isinstance(result, ThemeInfo): + await ctx.info( + "Theme information retrieved successfully: " + "id=%s, theme_name=%s, uuid=%s" + % (result.id, result.theme_name, result.uuid) + ) + else: + await ctx.warning( + "Theme retrieval failed: error_type=%s, error=%s" + % (result.error_type, result.error) + ) + + return result + + except Exception as e: Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Avoid catching blind Exception</b></div> <div id="fix"> Replace the broad `Exception` catch with specific exception types (e.g., `ValueError`, `AttributeError`, `ThemeDAO.NotFound`) to improve error handling and debugging. </div> </div> <small><i>Code Review Run #795631</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
