jesperct commented on PR #40220: URL: https://github.com/apache/superset/pull/40220#issuecomment-4520900995
Added both. UPDATING.md now calls out the behavior change: display values follow the sort toggle (A–Z, Z–A, or source order when unset), where the dropdown previously always sorted A–Z via the Select's default comparator. So existing dashboards where the toggle was never set will show source order, and enabling the toggle restores alphabetical ordering. For the test, I pulled the `GroupByFilterCard` sort comparator into a pure helper (`createLabelSortComparator`) and added unit tests for the three cases. The plugin path already had equivalent coverage in `DynamicGroupByPlugin.test.tsx`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
