rusackas commented on PR #40012:
URL: https://github.com/apache/superset/pull/40012#issuecomment-4522412780
Some things to assess/address:
- **`data-drag-source-id` / `data-drop-target-id` in `OptionControls`**:
These attributes ship on every `DragContainer` in production purely to
enable the new `TestBackend.simulate*` test pattern. Can we either gate
them behind `NODE_ENV !== 'production'`, rename to `data-test-*` and strip
at build time, or use `userEvent`'s native DnD simulation instead? I'd
rather not export react-dnd's internal handler IDs to prod DOM.
- **Half-done `defaultProps` cleanup**: `MetricsControl` got the
inline-default treatment but `AdhocFilterControl`, `FixedOrMetricControl`,
and `AdhocMetricEditPopover` still use `Component.defaultProps = {...}`
on the branch. Either all of them or none, please — partial cleanup leaves
the warning noise and obscures what's been migrated.
- **`@swc/plugin-emotion` downgrade**: `^14.10.0 → ^14.9.0` without
explanation — what's the compat reason? Worth calling out in the PR
description so the next person upgrading doesn't accidentally bump it
back.
- **DOM wrappers**: `AvatarGroup` now wraps `Avatar.Group` in `<span>`,
and `getControlItemsMap` adds a `<span>` around `StyledRowFormItem`. Have
you verified visually that no consuming layout (flex children, form-item
alignment, CSS selectors targeting direct children) breaks? If yes, all
good — if not, a smoke pass on the affected screens would be reassuring.
Rebase needed too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
